Update ng2-page-scroll to the latest version 🚀 #2360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.0.0-beta.11 of ng2-page-scroll just got published.
The version 4.0.0-beta.11 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ng2-page-scroll.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 36 commits.
5a5d488Changelog, bump version to 4.0.0-beta.1149b5175Set correct angular min version (fix #204)72faf1dRemove the "angular 2" terms from readme (#164)4d8bf67Adjust project description9b17032Changelog, bump version to 4.0.0-beta.10ae3e740Raise minimum angular version to 4.2.05d0ab20Some further dependency version updatesa1568caAdd warning to demo page that cross route scrolling currently does not work in all occasions637373dMake pageScrollTarget selector more generic (closes #193)5e3a501Remove deprecated pageScrollInstance factory methods1a78e61Enhance readme demo code importsba674c0Update to new location of DOCUMENT token (see angular/angular@2a7ebbe)49062ceMerge branch 'achimha-master' into develop25e40e7Remove android tests79f6031Test against new android versionThere are 36 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴