feat(rating): remove glyphicons, add custom template support #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSurmay
force-pushed
the
feat-rating-icons
branch
from
97aac2e to
1f98dc9
Compare
valorkin
pushed a commit
that referenced
this pull request
Sep 14, 2017
BREAKING CHANGES: - removed input properties stateOn, stateOff and ratingStates - custom icons now working via customTemplate
steelsojka
added a commit
to steelsojka/ngx-bootstrap
that referenced
this pull request
Sep 14, 2017
…ootstrap into development * 'development' of https://github.com/valor-software/ngx-bootstrap: fix(modals): fix issues with renderer2 in modal service fix(dropdown): prevent event propogation if dropdown toggle clicked fix(datepicker): added zindex to show datepicker above input fields fix(tests): fixed tests, change renderer to renderer2 fix(dropdown): fix ngv4 dropdowns (valor-software#2644) fix(tabs): fix default tab selection (valor-software#2643) feat(timepicker): replace glyphicons with custom icons (valor-software#2640) fix(modal): fix bsModalRef paths in demos (valor-software#2638) feat(rating): remove glyphicons, add custom template support (valor-software#2631) fix(datepicker): fix long date format (valor-software#2630) feat(moment-ts): added czech locale (valor-software#2642) feat(package): drop support of ng v2 and add support of ng v4 and v5 (valor-software#2602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
removed input properties
stateOn,stateOffandratingStatescustom icons now working via
customTemplate