Use !default for SASS variables #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to override the variables in SASS, each variable declaration should have a `!default` flag (http://sass-lang.com/documentation/file.SASS_REFERENCE.html#Variable_Defaults___default).
Codecov Report
@@ Coverage Diff @@
## development #2777 +/- ##
============================================
Coverage 70.49% 70.49%
============================================
Files 137 137
Lines 4088 4088
Branches 710 710
============================================
Hits 2882 2882
Misses 908 908
Partials 298 298Continue to review full report at Codecov.
|
|
@peschee thanks for PR! @EvilAlexei please review this changes, if it's looks good -> approve |
EvilAlexei
approved these changes
Oct 3, 2017
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to override the variables in SASS, each variable declaration should have a
!defaultflag (http://sass-lang.com/documentation/file.SASS_REFERENCE.html#Variable_Defaults___default).