Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabset component removeTab method doesn't work with Angular Universal… #2889

Conversation

amitgaikwad02bright
Copy link

#2778

added changes to use Renderer2 for removeChild

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 21, 2017

Codecov Report

Merging #2889 into development will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2889      +/-   ##
===============================================
+ Coverage        70.69%   70.69%   +<.01%     
===============================================
  Files              137      137              
  Lines             4159     4160       +1     
  Branches           735      735              
===============================================
+ Hits              2940     2941       +1     
  Misses             914      914              
  Partials           305      305
Impacted Files Coverage Δ
src/tabs/tabset.component.ts 82.25% <75%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479b046...a9e338a. Read the comment docs.

@IlyaSurmay
Copy link
Contributor

Closing in favor of #2925
Thanks for PR!

@IlyaSurmay IlyaSurmay closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants