Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): inside of onpush components #2946

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 1, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #2946 into development will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2946      +/-   ##
==============================================
- Coverage         70.7%   70.7%   -0.01%     
==============================================
  Files              137     137              
  Lines             4165    4168       +3     
  Branches           737     738       +1     
==============================================
+ Hits              2945    2947       +2     
  Misses             914     914              
- Partials           306     307       +1
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 70.61% <66.66%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b8454...b708339. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 44763a9 into development Nov 2, 2017
@valorkin valorkin deleted the fix-typeahead-in-onpush branch November 2, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants