-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): modal service v2 wip #3361
Conversation
0705db5
to
14b7dc1
Compare
Codecov Report
@@ Coverage Diff @@
## development #3361 +/- ##
===============================================
- Coverage 65.03% 64.89% -0.14%
===============================================
Files 210 211 +1
Lines 5691 5723 +32
Branches 1000 1000
===============================================
+ Hits 3701 3714 +13
- Misses 1724 1743 +19
Partials 266 266
Continue to review full report at Codecov.
|
14b7dc1
to
f80e6a2
Compare
f80e6a2
to
a7a53d1
Compare
…ithout .forRoot() in child modules
This seems like a great approach. Any update on this? |
@valorkin , this would be the great fix! |
Any progress on this? This is a high-value improvement! |
this approach is definitely better than existing one |
Totally outdated |
Closes #2917
Closes #2330
Fixes #2356
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.