Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): modal service v2 wip #3361

Closed
wants to merge 3 commits into from

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Dec 26, 2017

Closes #2917
Closes #2330
Fixes #2356

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #3361 into development will decrease coverage by 0.13%.
The diff coverage is 32.3%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3361      +/-   ##
===============================================
- Coverage        65.03%   64.89%   -0.14%     
===============================================
  Files              210      211       +1     
  Lines             5691     5723      +32     
  Branches          1000     1000              
===============================================
+ Hits              3701     3714      +13     
- Misses            1724     1743      +19     
  Partials           266      266
Impacted Files Coverage Δ
src/modal/modal.module.ts 91.66% <100%> (+0.75%) ⬆️
src/modal/bs-modal-ref.service.ts 33.33% <27.27%> (-41.67%) ⬇️
src/modal/bs-modal.service.ts 25.49% <28%> (+2.63%) ⬆️
src/modal/modal-container.component.ts 18.18% <33.33%> (-1.82%) ⬇️
src/modal/bs-modal.store.ts 42.85% <42.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a747c...4a8c942. Read the comment docs.

@IlyaSurmay IlyaSurmay force-pushed the feat-modal-service-v2 branch from 14b7dc1 to f80e6a2 Compare December 27, 2017 14:55
@IlyaSurmay IlyaSurmay force-pushed the feat-modal-service-v2 branch from f80e6a2 to a7a53d1 Compare December 27, 2017 14:55
@vincentjames501
Copy link

This seems like a great approach. Any update on this?

@vincentjames501
Copy link

@valorkin , this would be the great fix!

@gufigueiredo
Copy link

Any progress on this? This is a high-value improvement!

@valorkin
Copy link
Member

this approach is definitely better than existing one
but has the same issue with lazy loaded modules

@daniloff200
Copy link
Contributor

Totally outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment