Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): Hide container with timeout to allow other events to propagate. Fixes #363 #398

Merged

Conversation

fkowal
Copy link
Contributor

@fkowal fkowal commented Apr 12, 2016

Fixes #363

@valorkin
Copy link
Member

This is nice hack, thanks! :)

@johan13
Copy link

johan13 commented Apr 12, 2016

Where did the 10 ms come from? It feels a bit arbitrary.

If it is enough to wait until the next pass in the message pump, then I think we should sleep for 1 ms. (That is what _.defer() from lodash or underscore does.) If we need to sleep for more, then I am not comfortable with an arbitrary 10 ms. What if the browser runs on slow hardware or is heavily loaded at the time?

@valorkin
Copy link
Member

it is more likely I should do an event queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants