style: make manageUrl required #605
Conversation
src/apps/aave/positions.ts
Outdated
| @@ -175,6 +175,7 @@ const hook: PositionsHook = { | |||
| title: `Claimable rewards`, | |||
| description: 'For supplying and borrowing', | |||
| imageUrl: AAVE_LOGO, | |||
| manageUrl | |||
There was a problem hiding this comment.
I don't see this for allbridge too. I assume this is for making positions clickable right? Should this be a required field in the types then? Seems like this should be present for all positions. Or if some positions don't have a url we can link to, can we enforce it in TS so that this field is explicitly specified as undefined rather than keeping it optional?
There was a problem hiding this comment.
@satish-ravi Addressed in 6718123! Hopefully this more explicit definition will result in the manageUrl being provided more often.
MuckT
changed the title
|
@satish-ravi added a mangeUrls for all the apps except HaloFi, Locked-CELO, and Mento (Only swap page found). |
| @@ -124,6 +124,7 @@ const hook: PositionsHook = { | |||
| title: `${tokenInfo.symbol} supply incentives`, | |||
| description: 'Rewards for supplying', | |||
| imageUrl: ALLBRIDGE_LOGO, | |||
| manageUrl: `${ALLBRIDGE_POOLS_BASE_URL}?chain=${NETWORK_ID_TO_ALLBRIDGE_CHAIN[networkId]}`, | |||
There was a problem hiding this comment.
nit: could pull this to a local variable to avoid duplication
Description
Aave's ManageUrl was only used in dataProps and this PR adds it to displayProps.