This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Make implementation behave more like NodeJS net socket API #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues observed in celo-org/celo-monorepo#1422
The main problem was
react-native-tcp
behaved slightly differently from the NodeJS net socket implementation and resulted in the initial write to the socket being lost while connecting on Android and failing on iOS.This matches NodeJS implementation https://github.com/nodejs/node/blob/96a65e85c59ab4a81f49f7088d9f4d270980c5b0/lib/net.js#L233
I'm sure there are other edge cases, but it currently works as expected for our usage.