Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Make implementation behave more like NodeJS net socket API #3

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

jeanregisser
Copy link
Member

@jeanregisser jeanregisser commented Dec 18, 2019

This PR fixes issues observed in celo-org/celo-monorepo#1422

The main problem was react-native-tcp behaved slightly differently from the NodeJS net socket implementation and resulted in the initial write to the socket being lost while connecting on Android and failing on iOS.

I'm sure there are other edge cases, but it currently works as expected for our usage.

@jeanregisser jeanregisser merged commit 7956f69 into master Apr 28, 2020
@jeanregisser jeanregisser deleted the jeanregisser/fix-write-while-connecting branch April 28, 2020 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants