chore: add remote config variables for dapps explorer search and filt…

…er (#3460) ### Description Adds the remote config variables `dappsFilterEnabled` and `dappsSearchEnabled`. ### Test plan Tested locally with unit tests and in CI. ### Related issues - RET-581 ### Backwards compatibility Yes
valora-inc · Feb 23, 2023 · 621ddd2 · 621ddd2
1 parent 109bc32
commit 621ddd2
Show file tree

Hide file tree

Showing 11 changed files with 50 additions and 3 deletions.
diff --git a/src/app/saga.ts b/src/app/saga.ts
@@ -212,6 +212,8 @@ export interface RemoteConfigValues {
   guaranteedSwapPriceEnabled: boolean
   superchargeV2Enabled: boolean
   superchargeRewardContractAddress: string
+  dappsFilterEnabled: boolean
+  dappsSearchEnabled: boolean
 }
 
 export function* appRemoteFeatureFlagSaga() {

diff --git a/src/dapps/selectors.ts b/src/dapps/selectors.ts
@@ -100,3 +100,7 @@ export const favoriteDappsSelector = createSelector(
     return favoriteDapps
   }
 )
+
+export const dappsFilterEnabledSelector = (state: RootState) => state.dapps.dappsFilterEnabled
+
+export const dappsSearchEnabledSelector = (state: RootState) => state.dapps.dappsSearchEnabled
diff --git a/src/dapps/slice.ts b/src/dapps/slice.ts
@@ -18,6 +18,8 @@ export interface State {
   dappFavoritesEnabled: boolean
   favoriteDappIds: string[]
   dappsMinimalDisclaimerEnabled: boolean
+  dappsFilterEnabled: boolean
+  dappsSearchEnabled: boolean
 }
 
 const initialState: State = {
@@ -34,6 +36,8 @@ const initialState: State = {
   dappFavoritesEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.dappFavoritesEnabled,
   favoriteDappIds: [],
   dappsMinimalDisclaimerEnabled: false,
+  dappsFilterEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.dappsFilterEnabled,
+  dappsSearchEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.dappsSearchEnabled,
 }
 
 export interface DappSelectedAction {

diff --git a/src/firebase/firebase.ts b/src/firebase/firebase.ts
@@ -309,6 +309,8 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
     guaranteedSwapPriceEnabled: flags.guaranteedSwapPriceEnabled.asBoolean(),
     superchargeV2Enabled: flags.superchargeV2Enabled.asBoolean(),
     superchargeRewardContractAddress: flags.superchargeRewardContractAddress.asString(),
+    dappsFilterEnabled: flags.dappsFilterEnabled.asBoolean(),
+    dappsSearchEnabled: flags.dappsSearchEnabled.asBoolean(),
   }
 }
 

diff --git a/src/firebase/remoteConfigValuesDefaults.e2e.ts b/src/firebase/remoteConfigValuesDefaults.e2e.ts
@@ -71,4 +71,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   guaranteedSwapPriceEnabled: false,
   superchargeV2Enabled: false,
   superchargeRewardContractAddress: '',
+  dappsFilterEnabled: false,
+  dappsSearchEnabled: false,
 }
diff --git a/src/firebase/remoteConfigValuesDefaults.ts b/src/firebase/remoteConfigValuesDefaults.ts
@@ -73,4 +73,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   guaranteedSwapPriceEnabled: false,
   superchargeV2Enabled: false,
   superchargeRewardContractAddress: '',
+  dappsFilterEnabled: false,
+  dappsSearchEnabled: false,
 }
diff --git a/src/redux/migrations.ts b/src/redux/migrations.ts
@@ -1046,4 +1046,12 @@ export const migrations = {
     },
   }),
   111: (state: any) => state,
+  112: (state: any) => ({
+    ...state,
+    dapps: {
+      ...state.dapps,
+      dappsFilterEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.dappsFilterEnabled,
+      dappsSearchEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.dappsSearchEnabled,
+    },
+  }),
 }
diff --git a/src/redux/store.test.ts b/src/redux/store.test.ts
@@ -93,7 +93,7 @@ describe('store state', () => {
       Object {
         "_persist": Object {
           "rehydrated": true,
-          "version": 111,
+          "version": 112,
         },
         "account": Object {
           "acceptedTerms": false,
@@ -185,10 +185,12 @@ describe('store state', () => {
           "dappFavoritesEnabled": false,
           "dappListApiUrl": null,
           "dappsCategories": Array [],
+          "dappsFilterEnabled": false,
           "dappsList": Array [],
           "dappsListError": null,
           "dappsListLoading": false,
           "dappsMinimalDisclaimerEnabled": false,
+          "dappsSearchEnabled": false,
           "dappsWebViewEnabled": false,
           "favoriteDappIds": Array [],
           "maxNumRecentDapps": 0,

diff --git a/src/redux/store.ts b/src/redux/store.ts
@@ -23,7 +23,7 @@ const persistConfig: PersistConfig<RootState> = {
   key: 'root',
   // default is -1, increment as we make migrations
   // See https://github.com/valora-inc/wallet/tree/main/WALLET.md#redux-state-migration
-  version: 111,
+  version: 112,
   keyPrefix: `reduxStore-`, // the redux-persist default is `persist:` which doesn't work with some file systems.
   storage: FSStorage(),
   blacklist: ['networkInfo', 'alert', 'imports', 'supercharge', 'swap'],

diff --git a/test/RootStateSchema.json b/test/RootStateSchema.json
@@ -3176,6 +3176,9 @@
                     },
                     "type": "array"
                 },
+                "dappsFilterEnabled": {
+                    "type": "boolean"
+                },
                 "dappsList": {
                     "items": {
                         "$ref": "#/definitions/Dapp"
@@ -3194,6 +3197,9 @@
                 "dappsMinimalDisclaimerEnabled": {
                     "type": "boolean"
                 },
+                "dappsSearchEnabled": {
+                    "type": "boolean"
+                },
                 "dappsWebViewEnabled": {
                     "type": "boolean"
                 },
@@ -3219,10 +3225,12 @@
                 "dappFavoritesEnabled",
                 "dappListApiUrl",
                 "dappsCategories",
+                "dappsFilterEnabled",
                 "dappsList",
                 "dappsListError",
                 "dappsListLoading",
                 "dappsMinimalDisclaimerEnabled",
+                "dappsSearchEnabled",
                 "dappsWebViewEnabled",
                 "favoriteDappIds",
                 "maxNumRecentDapps",

diff --git a/test/schemas.ts b/test/schemas.ts
@@ -2052,6 +2052,19 @@ export const v111Schema = {
   },
 }
 
+export const v112Schema = {
+  ...v111Schema,
+  _persist: {
+    ...v111Schema._persist,
+    version: 112,
+  },
+  dapps: {
+    ...v111Schema.dapps,
+    dappsFilterEnabled: false,
+    dappsSearchEnabled: false,
+  },
+}
+
 export function getLatestSchema(): Partial<RootState> {
-  return v111Schema as Partial<RootState>
+  return v112Schema as Partial<RootState>
 }