Skip to content

Commit

Permalink
chore: Move KeylessBackupOrigin to types file (#5550)
Browse files Browse the repository at this point in the history
### Description

Addressing this comment:
#5537 (comment)

### Test plan

CI

### Related issues

- Fixes #ACT-1222

### Backwards compatibility

Yes

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [X] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)
  • Loading branch information
finnian0826 authored Jun 14, 2024
1 parent fd2a940 commit add6587
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 20 deletions.
7 changes: 5 additions & 2 deletions src/analytics/Properties.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ import { SerializableRewardsInfo } from 'src/earn/types'
import { ProviderSelectionAnalyticsData } from 'src/fiatExchanges/types'
import { CICOFlow, FiatExchangeFlow, PaymentMethod } from 'src/fiatExchanges/utils'
import { HomeActionName, NotificationBannerCTATypes, NotificationType } from 'src/home/types'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import { KeylessBackupFlow, KeylessBackupStatus } from 'src/keylessBackup/types'
import {
KeylessBackupFlow,
KeylessBackupOrigin,
KeylessBackupStatus,
} from 'src/keylessBackup/types'
import { LocalCurrencyCode } from 'src/localCurrency/consts'
import { NftOrigin } from 'src/nfts/types'
import { NotificationReceiveState } from 'src/notifications/types'
Expand Down
3 changes: 1 addition & 2 deletions src/keylessBackup/KeylessBackupIntro.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import React from 'react'
import { KeylessBackupEvents } from 'src/analytics/Events'
import ValoraAnalytics from 'src/analytics/ValoraAnalytics'
import KeylessBackupIntro from 'src/keylessBackup/KeylessBackupIntro'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import { KeylessBackupFlow } from 'src/keylessBackup/types'
import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
import { navigate } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
import MockedNavigator from 'test/MockedNavigator'
Expand Down
3 changes: 1 addition & 2 deletions src/keylessBackup/KeylessBackupIntro.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ import CancelButton from 'src/components/CancelButton'
import Card from 'src/components/Card'
import TextButton from 'src/components/TextButton'
import EnvelopeIcon from 'src/keylessBackup/EnvelopeIcon'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import SmartphoneIcon from 'src/keylessBackup/SmartphoneIcon'
import { KeylessBackupFlow } from 'src/keylessBackup/types'
import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
import { emptyHeader } from 'src/navigator/Headers'
import { navigate } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
Expand Down
8 changes: 6 additions & 2 deletions src/keylessBackup/KeylessBackupProgress.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ import * as React from 'react'
import { Provider } from 'react-redux'
import { KeylessBackupEvents } from 'src/analytics/Events'
import ValoraAnalytics from 'src/analytics/ValoraAnalytics'
import KeylessBackupProgress, { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import KeylessBackupProgress from 'src/keylessBackup/KeylessBackupProgress'
import { keylessBackupAcceptZeroBalance, keylessBackupBail } from 'src/keylessBackup/slice'
import { KeylessBackupFlow, KeylessBackupStatus } from 'src/keylessBackup/types'
import {
KeylessBackupFlow,
KeylessBackupOrigin,
KeylessBackupStatus,
} from 'src/keylessBackup/types'
import { ensurePincode, navigate, navigateHome } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
import { goToNextOnboardingScreen } from 'src/onboarding/steps'
Expand Down
11 changes: 5 additions & 6 deletions src/keylessBackup/KeylessBackupProgress.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ import { Help } from 'src/icons/Help'
import RedLoadingSpinnerToInfo from 'src/icons/RedLoadingSpinnerToInfo'
import { keylessBackupStatusSelector } from 'src/keylessBackup/selectors'
import { keylessBackupAcceptZeroBalance, keylessBackupBail } from 'src/keylessBackup/slice'
import { KeylessBackupFlow, KeylessBackupStatus } from 'src/keylessBackup/types'
import {
KeylessBackupFlow,
KeylessBackupOrigin,
KeylessBackupStatus,
} from 'src/keylessBackup/types'
import { useDollarsToLocalAmount, useLocalCurrencyCode } from 'src/localCurrency/hooks'
import { ensurePincode, navigate, navigateHome } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
Expand All @@ -32,11 +36,6 @@ import Logger from 'src/utils/Logger'

const TAG = 'keylessBackup/KeylessBackupProgress'

export enum KeylessBackupOrigin {
Onboarding = 'Onboarding',
Settings = 'Settings',
}

function KeylessBackupProgress({
route,
navigation,
Expand Down
5 changes: 5 additions & 0 deletions src/keylessBackup/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ export enum KeylessBackupDeleteStatus {
Completed = 'Completed',
Failed = 'Failed',
}

export enum KeylessBackupOrigin {
Onboarding = 'Onboarding',
Settings = 'Settings',
}
3 changes: 1 addition & 2 deletions src/navigator/types.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import FiatConnectQuote from 'src/fiatExchanges/quotes/FiatConnectQuote'
import { CICOFlow, FiatExchangeFlow, SimplexQuote } from 'src/fiatExchanges/utils'
import { Props as KycLandingProps } from 'src/fiatconnect/KycLanding'
import { FiatAccount } from 'src/fiatconnect/slice'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import { KeylessBackupFlow } from 'src/keylessBackup/types'
import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
import { Screens } from 'src/navigator/Screens'
import { Nft } from 'src/nfts/types'
import { Recipient } from 'src/recipients/recipient'
Expand Down
3 changes: 1 addition & 2 deletions src/onboarding/registration/ImportSelect.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import { fireEvent, render } from '@testing-library/react-native'
import * as React from 'react'
import 'react-native'
import { Provider } from 'react-redux'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import { KeylessBackupFlow } from 'src/keylessBackup/types'
import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
import { navigate } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
import ImportSelect from 'src/onboarding/registration/ImportSelect'
Expand Down
3 changes: 1 addition & 2 deletions src/onboarding/registration/ImportSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import Card from 'src/components/Card'
import Touchable from 'src/components/Touchable'
import CloudCheck from 'src/icons/CloudCheck'
import Lock from 'src/icons/Lock'
import { KeylessBackupOrigin } from 'src/keylessBackup/KeylessBackupProgress'
import { KeylessBackupFlow } from 'src/keylessBackup/types'
import { KeylessBackupFlow, KeylessBackupOrigin } from 'src/keylessBackup/types'
import { nuxNavigationOptions } from 'src/navigator/Headers'
import { navigate, navigateClearingStack } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
Expand Down

0 comments on commit add6587

Please sign in to comment.