test: re-enable secure send e2e test #4507
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| import { E2E_TEST_WALLET, E2E_TEST_WALLET_SECURE_SEND } from './consts' | ||
| import { checkBalance, getBalance } from './utils' | ||
| ;(async () => { | ||
| console.log(E2E_TEST_WALLET) | ||
| console.table(await getBalance(E2E_TEST_WALLET)) | ||
| await checkBalance(E2E_TEST_WALLET) | ||
|
|
||
| console.log(E2E_TEST_WALLET_SECURE_SEND) | ||
| console.table(await getBalance(E2E_TEST_WALLET_SECURE_SEND)) | ||
| await checkBalance(E2E_TEST_WALLET_SECURE_SEND, 2) | ||
| })() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export const E2E_TEST_WALLET = '0x6131a6d616a4be3737b38988847270a64bc10caa' | ||
| export const E2E_TEST_WALLET_SECURE_SEND = '0x86b8f44386cb2d457db79c3dab8cf42f9d8a3fc0' | ||
| export const E2E_TEST_FAUCET = '0xe5F5363e31351C38ac82DBAdeaD91Fd5a7B08846' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,7 @@ | ||
| import SecureSend from './usecases/SecureSend' | ||
| import Send from './usecases/Send' | ||
|
|
||
| describe('Given', () => { | ||
| describe('Send', Send) | ||
| describe('SecureSend with CPV', SecureSend) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,86 +1,92 @@ | ||
| import { | ||
| SAMPLE_BACKUP_KEY_VERIFIED, | ||
| VERIFIED_PHONE_NUMBER, | ||
| SAMPLE_WALLET_ADDRESS_VERIFIED_2, | ||
| } from '../utils/consts' | ||
| import { launchApp } from '../utils/retries' | ||
| import { | ||
| addComment, | ||
| enterPinUiIfNecessary, | ||
| inputNumberKeypad, | ||
| scrollIntoView, | ||
| quickOnboarding, | ||
| } from '../utils/utils' | ||
| const faker = require('@faker-js/faker') | ||
|
|
||
| const AMOUNT_TO_SEND = '0.01' | ||
|
|
||
| export default SecureSend = () => { | ||
| describe.each([{ web3Library: 'contract-kit' }, { web3Library: 'viem' }])( | ||
| 'Secure send flow with phone number lookup (with $web3Library)', | ||
| ({ web3Library }) => { | ||
| beforeAll(async () => { | ||
| // uninstall the app to remove secure send mapping | ||
| await device.uninstallApp() | ||
| await device.installApp() | ||
| await launchApp({ | ||
| newInstance: true, | ||
| permissions: { notifications: 'YES', contacts: 'YES' }, | ||
| launchArgs: { | ||
| statsigGateOverrides: `use_new_send_flow=false,use_viem_for_send=${ | ||
| web3Library === 'viem' | ||
| }`, | ||
| }, | ||
| }) | ||
| await quickOnboarding(SAMPLE_BACKUP_KEY_VERIFIED) | ||
| }) | ||
|
|
||
| it('Send cUSD to phone number with multiple mappings', async () => { | ||
| let randomContent = faker.lorem.words() | ||
| await waitFor(element(by.id('HomeAction-Send'))) | ||
| .toBeVisible() | ||
| .withTimeout(30000) | ||
| await element(by.id('HomeAction-Send')).tap() | ||
| await waitFor(element(by.id('SendSearchInput'))).toBeVisible() | ||
|
|
||
| await element(by.id('SearchInput')).tap() | ||
| await element(by.id('SearchInput')).replaceText(VERIFIED_PHONE_NUMBER) | ||
| await element(by.id('RecipientItem')).tap() | ||
|
|
||
| // Select the currency | ||
| await waitFor(element(by.id('cUSDTouchable'))).toBeVisible() | ||
| await element(by.id('cUSDTouchable')).tap() | ||
|
|
||
| // Enter the amount and review | ||
| await inputNumberKeypad(AMOUNT_TO_SEND) | ||
| await element(by.id('Review')).tap() | ||
|
|
||
| // Use the last digits of the account to confirm the sender. | ||
| await waitFor(element(by.id('confirmAccountButton'))).toBeVisible() | ||
| await element(by.id('confirmAccountButton')).tap() | ||
| // TODO: test case for AddressValidationType.PARTIAL but relies on mapping phone number to another address with unique last 4 digits | ||
| // for (let index = 0; index < 4; index++) { | ||
| // const character = LAST_ACCOUNT_CHARACTERS[index] | ||
| // await element(by.id(`SingleDigitInput/digit${index}`)).replaceText(character) | ||
| // } | ||
| await element(by.id('ValidateRecipientAccount/TextInput')).replaceText( | ||
| SAMPLE_WALLET_ADDRESS_VERIFIED_2 | ||
| ) | ||
|
|
||
|
Comment on lines
+66
to
+68
There was a problem hiding this comment. Why doesn't it need just the last 4 digits? We'd need 2 other verified accounts, to another number to test that case. There was a problem hiding this comment. if i understand correctly, the secure send screen either asks for the full address or the last 4 digits but this is depending on how "different" the possible addresses are. unfortunately we've mapped to 2 wallets and they both have a "0" in the last 4 digits of the address, so we've got the full text input. idk if it is too important to test both the full text input and the 4 digits, i have 90% confidence that both flows are working if i know one of them is working. we can try to remap to another address, but this is Tom's burner number and he's out all week so would need to wait till he's back There was a problem hiding this comment. Yes the current test is fine for now. For posterity, the check for uniqueness of the last 4 digits is done as a whole, but also includes the user's own address: wallet/src/identity/secureSend.ts Lines 59 to 62 in 2b28b69 It's not the fact that there are chars in common between them that causes |
||
| // Scroll to see submit button | ||
| await scrollIntoView('Submit', 'KeyboardAwareScrollView', 50) | ||
| await element(by.id('ConfirmAccountButton')).tap() | ||
|
|
||
| // Write a comment. | ||
| await addComment(randomContent) | ||
|
|
||
| // Confirm and input PIN if necessary. | ||
| await element(by.id('ConfirmButton')).tap() | ||
| await enterPinUiIfNecessary() | ||
|
|
||
| // Return to home screen. | ||
| await waitFor(element(by.id('HomeAction-Send'))) | ||
| .toBeVisible() | ||
| .withTimeout(30 * 1000) | ||
|
|
||
| await waitFor(element(by.text(`${randomContent}`))) | ||
| .toBeVisible() | ||
| .withTimeout(60000) | ||
| }) | ||
| } | ||
| ) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this gonna mix/overwrite balances between both accounts?
Where do we actually send to
E2E_TEST_WALLET_SECURE_SEND?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol oops, this logic didn't make sense. i've updated the script, sorry about that