-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency react-native-url-polyfill to v2 #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5356 +/- ##
==========================================
- Coverage 85.90% 85.89% -0.01%
==========================================
Files 737 737
Lines 30140 30140
Branches 5165 5165
==========================================
- Hits 25891 25890 -1
- Misses 4017 4018 +1
Partials 232 232 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…inc#5356) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-url-polyfill](https://github.com/charpeni/react-native-url-polyfill) | [`^1.3.0` -> `^2.0.0`](https://renovatebot.com/diffs/npm/react-native-url-polyfill/1.3.0/2.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-url-polyfill/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-url-polyfill/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-url-polyfill/1.3.0/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-url-polyfill/1.3.0/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charpeni/react-native-url-polyfill (react-native-url-polyfill)</summary> ### [`v2.0.0`](https://github.com/charpeni/react-native-url-polyfill/releases/tag/v2.0.0) [Compare Source](https://github.com/charpeni/react-native-url-polyfill/compare/v1.3.0...v2.0.0) #### Highlights >⚠️ It was released as a major version because it contains significant changes, but we don't expect any breaking changes. The upgrade should be seamless. ##### Official support for Expo & web. We're now testing `react-native-url-polyfill` against latest versions of Expo to prevent any issues. Also, previously, relying on `react-native-url-polyfill/auto` would also apply the polyfill if executed on the web (e.g., via `react-native-web`). Starting from now, `react-native-url-polyfill/auto` won't apply on the web platform and will be a no-op. If you would like to still apply it on web, you'll need to rely on `setupPolyfill` directly as such: ```js import { setupURLPolyfill } from 'react-native-url-polyfill'; setupURLPolyfill(); ``` ##### Moving away from React Native's internals To better support different versions of React Native and web usages, we moved away from using `polyfillGlobal`, which is part of React Native's internals. Instead, we use `globalThis`. See [https://github.com/charpeni/react-native-url-polyfill/pull/373](https://github.com/charpeni/react-native-url-polyfill/pull/373) and [https://github.com/charpeni/react-native-url-polyfill/pull/413](https://github.com/charpeni/react-native-url-polyfill/pull/413). #### What's Changed - Remove usage of RN's polyfillGlobal by [@​charpeni](https://github.com/charpeni) in [https://github.com/charpeni/react-native-url-polyfill/pull/373](https://github.com/charpeni/react-native-url-polyfill/pull/373) - Fix a phrasing issue in README by [@​plbrault](https://github.com/plbrault) in [https://github.com/charpeni/react-native-url-polyfill/pull/442](https://github.com/charpeni/react-native-url-polyfill/pull/442) - Add test for Expo 48 by [@​charpeni](https://github.com/charpeni) in [https://github.com/charpeni/react-native-url-polyfill/pull/453](https://github.com/charpeni/react-native-url-polyfill/pull/453) - Use globalThis instead of global in auto.js by [@​staltz](https://github.com/staltz) in [https://github.com/charpeni/react-native-url-polyfill/pull/413](https://github.com/charpeni/react-native-url-polyfill/pull/413) - Fix Typescript error by [@​raykle](https://github.com/raykle) in [https://github.com/charpeni/react-native-url-polyfill/pull/444](https://github.com/charpeni/react-native-url-polyfill/pull/444) - Add `bundle-size` script by [@​charpeni](https://github.com/charpeni) in [https://github.com/charpeni/react-native-url-polyfill/pull/455](https://github.com/charpeni/react-native-url-polyfill/pull/455) - Don't auto polyfill on web by [@​charpeni](https://github.com/charpeni) in [https://github.com/charpeni/react-native-url-polyfill/pull/456](https://github.com/charpeni/react-native-url-polyfill/pull/456) - Only default export is available soon by [@​charpeni](https://github.com/charpeni) in [https://github.com/charpeni/react-native-url-polyfill/pull/458](https://github.com/charpeni/react-native-url-polyfill/pull/458) #### New Contributors - [@​plbrault](https://github.com/plbrault) made their first contribution in [https://github.com/charpeni/react-native-url-polyfill/pull/442](https://github.com/charpeni/react-native-url-polyfill/pull/442) - [@​staltz](https://github.com/staltz) made their first contribution in [https://github.com/charpeni/react-native-url-polyfill/pull/413](https://github.com/charpeni/react-native-url-polyfill/pull/413) - [@​raykle](https://github.com/raykle) made their first contribution in [https://github.com/charpeni/react-native-url-polyfill/pull/444](https://github.com/charpeni/react-native-url-polyfill/pull/444) **Full Changelog**: charpeni/react-native-url-polyfill@v1.3.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^1.3.0
->^2.0.0
Release Notes
charpeni/react-native-url-polyfill (react-native-url-polyfill)
v2.0.0
Compare Source
Highlights
Official support for Expo & web.
We're now testing
react-native-url-polyfill
against latest versions of Expo to prevent any issues.Also, previously, relying on
react-native-url-polyfill/auto
would also apply the polyfill if executed on the web (e.g., viareact-native-web
). Starting from now,react-native-url-polyfill/auto
won't apply on the web platform and will be a no-op. If you would like to still apply it on web, you'll need to rely onsetupPolyfill
directly as such:Moving away from React Native's internals
To better support different versions of React Native and web usages, we moved away from using
polyfillGlobal
, which is part of React Native's internals. Instead, we useglobalThis
. See https://github.com/charpeni/react-native-url-polyfill/pull/373 and https://github.com/charpeni/react-native-url-polyfill/pull/413.What's Changed
bundle-size
script by @charpeni in https://github.com/charpeni/react-native-url-polyfill/pull/455New Contributors
Full Changelog: charpeni/react-native-url-polyfill@v1.3.0...v2.0.0
Configuration
📅 Schedule: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles.
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.