Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): ignore ws vulnerability #5553

Merged
merged 3 commits into from
Jun 18, 2024
Merged

build(deps): ignore ws vulnerability #5553

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
368a1f4
build(deps): add ws resolution
MuckT Jun 17, 2024
78eb23c
build(deps): use correct ws resolution per version
MuckT Jun 17, 2024
5d1cda7
chore(deps): ignore ws vulnerability
MuckT Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,11 @@
"browserify-sign": "^4.2.3",
"follow-redirects": "^1.15.6",
"redux": "^5.0.1",
"braces": "^3.0.3"
"braces": "^3.0.3",
"ws@5.0.0": "^5.2.4",
"ws@6.0.0": "^6.2.3",
"ws@7.0.0": "^7.5.10",
"ws@8.0.0": "^8.17.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you'd need to use ws@5.x, ws@6.x, etc. This seems like it would resolve only exact 5.0.0, 6.0.0 versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't work either. Based on @jh2oman response in Slack; I've opted to ignore the vulnerability.

},
"detox": {
"testRunner": {
Expand Down
17 changes: 11 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19326,6 +19326,11 @@ write-file-atomic@^4.0.2:
imurmurhash "^0.1.4"
signal-exit "^3.0.7"

ws@5.0.0@^5.2.4, ws@6.0.0@^6.2.3, ws@7.0.0@^7.5.10, ws@8.0.0@^8.17.1:
MuckT marked this conversation as resolved.
Show resolved Hide resolved
version "8.17.1"
resolved "https://registry.yarnpkg.com/ws/-/ws-8.17.1.tgz#9293da530bb548febc95371d90f9c878727d919b"
integrity sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==

ws@7.4.6:
MuckT marked this conversation as resolved.
Show resolved Hide resolved
version "7.4.6"
resolved "https://registry.yarnpkg.com/ws/-/ws-7.4.6.tgz#5654ca8ecdeee47c33a9a4bf6d28e2be2980377c"
Expand All @@ -19351,16 +19356,16 @@ ws@^3.0.0:
ultron "~1.1.0"

ws@^6.2.2:
version "6.2.2"
resolved "https://registry.yarnpkg.com/ws/-/ws-6.2.2.tgz#dd5cdbd57a9979916097652d78f1cc5faea0c32e"
integrity sha512-zmhltoSR8u1cnDsD43TX59mzoMZsLKqUweyYBAIvTngR3shc0W6aOZylZmq/7hqyVxPdi+5Ud2QInblgyE72fw==
version "6.2.3"
resolved "https://registry.yarnpkg.com/ws/-/ws-6.2.3.tgz#ccc96e4add5fd6fedbc491903075c85c5a11d9ee"
integrity sha512-jmTjYU0j60B+vHey6TfR3Z7RD61z/hmxBS3VMSGIrroOWXQEneK1zNuotOUrGyBHQj0yrpsLHPWtigEFd13ndA==
dependencies:
async-limiter "~1.0.0"

ws@^7, ws@^7.0.0, ws@^7.5.0, ws@^7.5.1:
version "7.5.3"
resolved "https://registry.yarnpkg.com/ws/-/ws-7.5.3.tgz#160835b63c7d97bfab418fc1b8a9fced2ac01a74"
integrity sha512-kQ/dHIzuLrS6Je9+uv81ueZomEwH0qVYstcAQ4/Z93K8zeko9gtAbttJWzoC5ukqXY1PpoouV3+VSOqEAFt5wg==
version "7.5.10"
resolved "https://registry.yarnpkg.com/ws/-/ws-7.5.10.tgz#58b5c20dc281633f6c19113f39b349bd8bd558d9"
integrity sha512-+dbF1tHwZpXcbOJdVOkzLDxZP1ailvSxM6ZweXTegylPny803bFhA+vqBYw4s31NSAk4S2Qz+AKXK9a4wkdjcQ==

xcode@^3.0.1:
version "3.0.1"
Expand Down
Loading