Resolve markets with mech requests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoreira-valory
changed the base branch from
feat/integrate_resolve_market_reasoning_tool
to
main
Adamantios
reviewed
Mar 4, 2024
Adamantios
reviewed
Mar 4, 2024
Adamantios
reviewed
Mar 4, 2024
packages/valory/skills/market_creation_manager_abci/behaviours.py
Outdated
Show resolved
Hide resolved
Adamantios
reviewed
Mar 4, 2024
Comment on lines
+2337
to
+2338
| question_id = question["question"]["id"].lower() | ||
| if question_id in self.shared_state.questions_requested_mech: |
There was a problem hiding this comment.
Why are the questions_requested_mech not in the synced db?
There was a problem hiding this comment.
This was the similar approach designed previously. Since it's a single-agent service, it's easier to use the shared state in this case.
There was a problem hiding this comment.
Makes sense but we need to remember if we convert this to a multi-agent service.
Adamantios
reviewed
Mar 4, 2024
Adamantios
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main branch (bump)
Resolve markets with mech requests