Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multi-ledger support on termination skill from IEKIT #2144

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

angrybayblade
Copy link
Contributor

@angrybayblade angrybayblade commented Jan 22, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

fixes #2125

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68b4313) 94.52% compared to head (4f8c1ab) 94.52%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/valory/skills/termination_abci/rounds.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2144   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         259      259           
  Lines       15914    15919    +5     
=======================================
+ Hits        15043    15048    +5     
  Misses        871      871           
Flag Coverage Δ
unittests 94.52% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -135,6 +135,8 @@ models:
use_slashing: false
use_termination: false
validate_timeout: 1205
termination_from_block: 0
termination_chain: gnosis
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt the chain be configurable?

Copy link
Collaborator

@dvilelaf dvilelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Some e2e failure, not sure if expected.

Copy link
Collaborator

@dvilelaf dvilelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are the e2e failures expected?

@angrybayblade angrybayblade merged commit cb017f7 into main Jan 23, 2024
23 of 24 checks passed
@DavidMinarsch DavidMinarsch deleted the fix/2125 branch March 13, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Termination abci needs multiledger support
3 participants