-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port multi-ledger support on termination skill from IEKIT #2144
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 259 259
Lines 15914 15919 +5
=======================================
+ Hits 15043 15048 +5
Misses 871 871
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -135,6 +135,8 @@ models: | |||
use_slashing: false | |||
use_termination: false | |||
validate_timeout: 1205 | |||
termination_from_block: 0 | |||
termination_chain: gnosis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt the chain be configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Some e2e failure, not sure if expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are the e2e failures expected?
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
fixes #2125
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.