Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: let travis build with dev channel of dart #72

Merged
merged 5 commits into from
Apr 14, 2018
Merged

chore: let travis build with dev channel of dart #72

merged 5 commits into from
Apr 14, 2018

Conversation

valotas
Copy link
Owner

@valotas valotas commented Apr 14, 2018 •
edited
Loading

  • add --preview-dart-2 to the analyzer

@coveralls
Copy link

coveralls commented Apr 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 91.975% when pulling 8d3b82e on build-with-dev into 6d4a701 on master.

@valotas valotas force-pushed the build-with-dev branch 5 times, most recently from 0b2867d to c3453ad Compare April 14, 2018 20:21
@valotas valotas merged commit b05e656 into master Apr 14, 2018
devoncarew
devoncarew reviewed Apr 14, 2018
View reviewed changes
Copy link

@devoncarew devoncarew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also want to consider testing running this library's code with preview dart 2 at runtime. That'll catch issues that the analyze won't be able to (runtime only ones). Something like:

  • dart --preview-dart-2 example/simpleusage.dart
  • dart --preview-dart-2 test/mustache_all.dart

build.sh
dartanalyzer --strong --fatal-warnings lib/*.dart test/*.dart
dartanalyzer="dartanalyzer --strong --fatal-warnings lib/*.dart test/*.dart"
if [ "$TRAVIS_DART_VERSION" = "dev" ]; then
dartanalyzer="$dartanalyzer --preview-dart-2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi, at this point, --preview-dart-2 to the analyzer is the same as --strong plus supporting optional new and const.

@valotas
Copy link
Owner Author

valotas commented Apr 14, 2018

I'll give it a try. If not in master branch for sure in dart2 branch where I only build against v2 of the vm. master should for the moment remain backwards compatible with v1 of the vm

@devoncarew
Copy link

Just FYI, all of the type changes for Dart 2 are backwards compatible with Dart 1. There are some constant renames (dart:convert JSON ==> json) that will be removed from Dart 1 - doing those renames wouldn't be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valotas @coveralls @devoncarew