Add Go 1.19 Support #1355
Add Go 1.19 Support #1355
Conversation
Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text. ref: https://tip.golang.org/doc/go1.19 ref: https://tip.golang.org/doc/comment
|
TBR |
doc.go
Outdated
| - Server and client address. | ||
|
|
||
| - Per-request logger. | ||
|
|
||
| - Unique request id. | ||
|
|
||
| - Request start time. | ||
|
|
||
| - Connection start time. | ||
|
|
||
| - Request sequence number for the current connection. |
There was a problem hiding this comment.
These need to be sub bullet points like the original.
doc.go
Outdated
| - The number of concurrent connections. | ||
|
|
||
| - The number of concurrent connections per client IP. | ||
|
|
||
| - The number of requests per connection. | ||
|
|
||
| - Request read timeout. | ||
|
|
||
| - Response write timeout. | ||
|
|
||
| - Maximum request header size. | ||
|
|
||
| - Maximum request body size. | ||
|
|
||
| - Maximum request execution time. | ||
|
|
||
| - Maximum keep-alive connection lifetime. | ||
|
|
||
| - Early filtering out non-GET requests. |
There was a problem hiding this comment.
These need to be sub bullet points like the original.
|
@erikdubbelboer Go doc comments do not support nested lists. https://tip.golang.org/doc/comment#mistakes Maybe we can mix list markers like the example? Since bullet markers do not introduce list items in a numbered list. |
|
Thanks! |
| go-version: 1.18.x | ||
| go-version: 1.19.x | ||
|
|
||
| - name: Get Go cache paths |
There was a problem hiding this comment.
@Aoang curious why you ended up doing this? In wazero, we're noticing the cache doesn't seem to work for golangci-lint and wondering if there's some difference between this and hard-coding (considering it is only run with ubuntu). Any thoughts appreciated!
https://github.com/tetratelabs/wazero/blob/main/.github/workflows/commit.yaml#L46-L52
There was a problem hiding this comment.
continue tetratelabs/wazero#804
* Update Go Version to Go1.19.x And add cache * Fix CI Line endings * Update test CI Go Version to Go1.19.x And add cache * Update Gosec Security Scanner CI to securego/gosec@v2.12.0 * Format comment Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text. ref: https://tip.golang.org/doc/go1.19 ref: https://tip.golang.org/doc/comment * Fix doc structure
No description provided.