Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
fasthttpadaptor
by reducing the overhead of slice growth.The current adapter records all written body in a byte slice, which causes horrible overhead when the body is bigger than a few kilobytes. However, this is unnecessary as we can just pass the response writer of fasthttp.
fasthttp/fasthttpadaptor/adaptor.go
Lines 108 to 111 in ea60524
I compared the performance by modifying the
ServerGet
tests with 32 KiB responses.The original
ServerGet
without the adaptor:The
ServerGet
with the current adaptor:The
ServerGet
with the patched adaptor: