fix: client may remove hostclient incorrectly #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
suggested changes
Dec 28, 2022
li-jin-gou
approved these changes
Dec 28, 2022
|
Thanks, good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleaner may remove hostclient unexpectedly.
I find that client will start cleaner when the first hostclient created.
The cleaner will remove hostclient if there is no conn in the hostclient. And cleaner will start judge logic immediately. At the same time, hostclient will create conn. So if client get the connsLock before hostclient create conn, the hostclient will be removed.
It may cause resource leak.