Change empty string checks to be more idiomatic #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
gocritic-empty-string-test
branch
from
d920617 to
477db14
Compare
|
Thanks! |
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 11, 2024
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 12, 2024
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 12, 2024
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 12, 2024
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 12, 2024
Max-Cheng
added a commit
to Max-Cheng/fasthttp
that referenced
this pull request
Feb 12, 2024
erikdubbelboer
pushed a commit
that referenced
this pull request
Feb 21, 2024
erikdubbelboer
added a commit
that referenced
this pull request
Feb 21, 2024
* feat:support zstd compress and uncompressed * fix:real & stackless write using different pool to avoid get stackless.writer * fix:zstd normalize compress level * Change empty string checks to be more idiomatic (#1684) * chore:lint fix and rebase with master * chore:remove 1.18 test & upgrade compress version * fix:error default compress level * Fix lint --------- Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors code by changing
if len(str) == 0 {to more idiomaticif str == "" {. Additionally, enables gocritic'semptyStringTestcheck to prevent such code in the future.See "Empty string check".