Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, fasthttp would never use zstd if clients sent their
Accept-Encoding
header including gzip because zstd was the last option and would only be used if zstd was the only encoding available inAccept-Encoding
header. This is really an issue when serving precompressed sidecars of zstd and gzip where the server preferred the latter.The following order has been established; first brotli, then zstd, and finally gzip. It takes into account whether
CompressBrotli
and the newCompressZstd
option are enabled to select which compression to use.It also fixes the missing Vary header on compressed assets.
There is also an issue that has been revealed with the rework of these tests that should be addressed in a separate PR