Various changes regarding code readibility #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, sort.Strings is the shortcut of Sort(StringSlice(a)) but its more readable.
Although its only occured on test files, it may be worth to simplified it.
Both have the same O(n), but strings.Contains more readable on if-condition.
If we assign the variable after declaring it, we can simplify it using ":=" operator or "= value". The reader can still known the type of variable from the struct name or variable type before assignment operator.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
07f0c88 (Shulhan, 2 hours ago)
all: simplify variable initialization
If we assign the variable after declaring it, we can simplify it using
":=" operator or "= value". The reader can still known the type of variable
from the struct name or variable type before assignment operator.
7e00ec6 (Shulhan, 2 hours ago)
args: simplify if-condition check on boolean value
cf6c51e (Shulhan, 2 hours ago)
http_test: simplify strings.Index with strings.Contains
Both have the same O(n), but strings.Contains more readable on
if-condition.
8439088 (Shulhan, 2 hours ago)
all: replace string(bytes.Buffer.Bytes()) with bytes.Buffer.String()
Although its only occured on test files, it may be worth to simplified it.
5f1f929 (Shulhan, 2 hours ago)
all: use sort.Strings when applicable
Basically, sort.Strings is the shortcut of Sort(StringSlice(a)) but its
more readable.