Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A faster s2b function #637

Merged
merged 4 commits into from
Aug 19, 2019
Merged

A faster s2b function #637

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07392d8
Update bytesconv.go
zhangyunhao116 Aug 18, 2019
54aa990
Fix
zhangyunhao116 Aug 18, 2019
3e98d1c
Min stack space
zhangyunhao116 Aug 18, 2019
c48d373
Use pointer for smaller stack space
zhangyunhao116 Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions bytesconv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,14 +384,13 @@ func b2s(b []byte) string {
//
// Note it may break if string and/or slice header will change
// in the future go versions.
func s2b(s string) []byte {
sh := (*reflect.StringHeader)(unsafe.Pointer(&s))
bh := reflect.SliceHeader{
Data: sh.Data,
Len: sh.Len,
Cap: sh.Len,
}
return *(*[]byte)(unsafe.Pointer(&bh))
func s2b(s string) (b []byte) {
bh := (*reflect.SliceHeader)(unsafe.Pointer(&b))
sh := *(*reflect.StringHeader)(unsafe.Pointer(&s))
erikdubbelboer marked this conversation as resolved.
Show resolved Hide resolved
bh.Data = sh.Data
bh.Len = sh.Len
bh.Cap = sh.Len
return b
}

// AppendUnquotedArg appends url-decoded src to dst and returns appended dst.
Expand Down