Allow client to disable path normalization #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the test for context - basically I have a URL like http://google.com/encoded/Y%2BY%2FY%3D/stuff, but when I use fasthttp, due to path normalization the actual request that gets made is to http://google.com/encoded/Y+Y/Y=/stuff. On some servers (e.g. fasthttp's server), these URLs are semantically equivalent, but on some servers (e.g. those google urls) they are not. If you click through those URLs you can see the difference in the 404 page that google returns. https://stackoverflow.com/questions/1957115/is-a-slash-equivalent-to-an-encoded-slash-2f-in-the-path-portion-of-a has some more context on the server-side situation as well.
This wires #649 through the client layer to solve this issue.