Forward context in fasthttpadaptor #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Jan 10, 2020
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/valyala/fasthttp | |||
| module github.com/lovromazgon/fasthttp | |||
There was a problem hiding this comment.
We obviously can't merge this pull request with this change.
There was a problem hiding this comment.
Sorry, removed it!
erikdubbelboer
requested changes
Jan 10, 2020
fasthttpadaptor/adaptor_test.go
Outdated
| ctx.SetUserValue(key, value) | ||
| next(ctx) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you please go fmt this file.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the request in fasthttpadaptor has a background context. It would be beneficial to set it to
fasthttp.RequestCtxor at least forward values that are already set in the context. This would allow us to retrieve any value that was set in middleware before the request reached thehttp.Handler.