Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the security issue of GoSec #762

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Resolve the security issue of GoSec #762

merged 2 commits into from
Mar 13, 2020

Conversation

panjf2000
Copy link
Contributor

No description provided.

@panjf2000
Copy link
Contributor Author

/cc @erikdubbelboer

@dgrr
Copy link
Contributor

dgrr commented Mar 12, 2020

What's the issue about? Can you explain a little?

@panjf2000
Copy link
Contributor Author

To resolve the security issue: https://github.com/valyala/fasthttp/pull/755/checks?check_run_id=497717442

[/home/runner/work/fasthttp/fasthttp/server.go:910] - G307 (CWE-): Deferring unsafe method "*os.File" on type "Close" (Confidence: HIGH, Severity: MEDIUM)
  > defer ff.Close()

@dgrr

@panjf2000
Copy link
Contributor Author

#755 (comment)

@erikdubbelboer erikdubbelboer merged commit 0b93308 into valyala:master Mar 13, 2020
@erikdubbelboer
Copy link
Collaborator

Thanks!

@panjf2000 panjf2000 deleted the patch-2 branch March 13, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panjf2000 @dgrr @erikdubbelboer