Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gracefilly shutdown bug, issue #958 #960

Merged
merged 6 commits into from
Feb 7, 2021
Merged

fix gracefilly shutdown bug, issue #958 #960

merged 6 commits into from
Feb 7, 2021

Conversation

alpha-baby
Copy link
Contributor

unit test

$ go test . -v -run=^TestShutdown$
=== RUN   TestShutdown
=== PAUSE TestShutdown
=== CONT  TestShutdown
--- PASS: TestShutdown (0.51s)
PASS
ok      github.com/valyala/fasthttp     0.530s

@erikdubbelboer
Copy link
Collaborator

See: #958 (comment)

erikdubbelboer
erikdubbelboer requested changes Feb 7, 2021
View reviewed changes
server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
alpha-baby and others added 2 commits February 7, 2021 18:26
@alpha-baby @erikdubbelboer
Update server.go
82a7dad 
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
@alpha-baby @erikdubbelboer
Update server.go
e91f8d0 
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
@alpha-baby
Copy link
Contributor Author

@erikdubbelboer can you fix this unit test, becase i'm not hava windwos PC.

@erikdubbelboer
Copy link
Collaborator

The tests are a bit flaky, everything seems fine so I'm merging this. Thanks!

@erikdubbelboer erikdubbelboer merged commit a88030b into valyala:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
pending/development pending/submitter-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpha-baby @erikdubbelboer