Refactor asm report #194
Merged
Refactor asm report #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit de57933 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 86.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.4%. View more on Code Climate. |
siebrenf
added a commit
that referenced
this pull request
Jan 6, 2022
* quiet init + better error * fix header issue with asm_report (#193) * Refactor asm report (#194) * update ensembl provider test * fix tests, oops * single function to download ncbi asm reports * dl_asm_rep mkdir * linting * Ucsc (#195) * test coverage * 'na' to None * added genomepy -v flag * set asm_report dtype * Update CHANGELOG.md * version 0.11.1 * typo release docs Co-authored-by: Simon van Heeringen <simon.vanheeringen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #187
Assembly reports are now downloaded by only one function, without inheritance issues.
During testing, there were
only a handful of4 genomes for which it didn't work. (ex: UCSC's gorGor5)