Minor iteration optimizations (elixir-lsp#527)

* perf: Remove iteration with Enum.map_join/3 * perf: Remove another iteration with Enum.map_join/3 * perf: Remove iteration using Map.new/2
vanjabucic · Jul 5, 2021 · 99a883e · 99a883e
1 parent bb57268
commit 99a883e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/apps/language_server/lib/language_server/diagnostics.ex b/apps/language_server/lib/language_server/diagnostics.ex
@@ -48,8 +48,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
       if stacktrace != [] do
         stacktrace =
           stacktrace
-          |> Enum.map(&"  │ #{&1}")
-          |> Enum.join("\n")
+          |> Enum.map_join("\n", &"  │ #{&1}")
           |> String.trim_trailing()
 
         description <> "\n\n" <> "Stacktrace:\n" <> stacktrace

diff --git a/apps/language_server/lib/language_server/providers/execute_command/apply_spec.ex b/apps/language_server/lib/language_server/providers/execute_command/apply_spec.ex
@@ -66,8 +66,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ApplySpec do
         Code.format_string!("@spec #{spec}", line_length: target_line_length)
         |> IO.iodata_to_binary()
         |> SourceFile.lines()
-        |> Enum.map(&(indentation <> &1))
-        |> Enum.join("\n")
+        |> Enum.map_join("\n", &(indentation <> &1))
         |> Kernel.<>("\n")
       rescue
         _ ->

diff --git a/apps/language_server/test/source_file_test.exs b/apps/language_server/test/source_file_test.exs
@@ -83,8 +83,7 @@ defmodule ElixirLS.LanguageServer.SourceFileTest do
       |> elem(0)
       |> Enum.reverse()
       |> Enum.with_index()
-      |> Enum.map(fn {off, ind} -> {ind, off} end)
-      |> Enum.into(%{})
+      |> Map.new(fn {off, ind} -> {ind, off} end)
     end
 
     defp find_low_high(low, high, offset, line_offsets) when low < high do