/x/net/http upgrade breaking change
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzuidhof
changed the title
/x/net/http upgrade breaks/x/net/http upgrade breaking change
|
Seeing the same issue here, where conditional comments are broken: Old output New (bad) output |
|
Can anyone help me following those issues and upgrades? thanks |
|
After additional digging, this issue is not resolved in x/net. I've added a note to golang/go#46261 indicating where the bug was introduced. |
|
dependabot upgraded golang.org/x/net #20 and it seems work fine? |
|
Look like tests passed if I upgraded golang.org/x/net to v0.23.0. Could you try it out then I can merge this instead of of #20 |
|
Look like it works fine so I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test case that breaks when you upgrade
golang.org/x/net, which broke the Hermes e-mail templating package downstream.This requires a downstream update of
goquery, and/x/net/http. I believe that /x/net/http was resolved, but Goquery hasn't upgraded yet PuerkitoBio/goquery#391. After it has, the version here should be bumped too.