Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Graph: Add dependencies from the root (declaration) nodes only #168

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Project Graph: Add dependencies from the root (declaration) nodes only #168

merged 1 commit into from
Jun 10, 2022

Conversation

SimonMarquis
Copy link
Contributor

Closes nidi3/graphviz-java#234
Closes #167

Not sure if this is an issue on the nidi3/graphviz-java repository. But there is no direct function to access declared nodes, meaning nodes without links (not edges).

@vanniktech
Copy link
Owner

Oh wow.

@SimonMarquis
Copy link
Contributor Author

SimonMarquis commented Jun 10, 2022

nodes() internally uses a Set which does not preserve any order.

https://github.com/nidi3/graphviz-java/blob/f0c1fdfa37c8b9876ef1dcccec1a6c19219e727e/graphviz-java/src/main/java/guru/nidi/graphviz/model/MutableGraph.java#L171-L173

@vanniktech vanniktech changed the title Add dependencies from the root (declaration) nodes only Project Graph: Add dependencies from the root (declaration) nodes only Jun 10, 2022
@vanniktech
Copy link
Owner

Thanks for finding this, already verified it on my branch ❤️

@vanniktech vanniktech merged commit 8f7c829 into vanniktech:master Jun 10, 2022
@SimonMarquis SimonMarquis deleted the fix/graph-nodes branch June 10, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a fill color yields an entirely separated graph
2 participants