The callback of log(info, callback) was used in a wrong manner #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e6e51f which lead to the following issues: - the @timestamp is wrong because the transformer is only called every 2 seconds by default (flushInterval for bulk write) - other transports are stopped for flushInterval because the callback isn't called For further information about correct use of the callback please read https://github.com/winstonjs/winston/blob/master/lib/winston/logger.js For tests please clone https://github.com/litti/test-winston-elasticsearch and change the version of winston-elasticsearch in package.json to 0.7.3, 0.7.4 and git+https://github.com/litti/winston-elasticsearch.git. After each change run `node app.js`. Watch the logs in console and the timestamps in your elastichsearch log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de6e51f introduced the wrong use of callback in
log(info, callback)which lead to the following issues:For further information about correct use of the callback please read https://github.com/winstonjs/winston/blob/master/lib/winston/logger.js
For tests please clone https://github.com/litti/test-winston-elasticsearch and change the version of winston-elasticsearch in package.json to 0.7.3, 0.7.4 and git+https://github.com/litti/winston-elasticsearch.git. After each change run
node app.js. Watch the logs in console and the timestamps in your elastichsearch log.