Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X (Twitter) #110

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Add X (Twitter) #110

wants to merge 37 commits into from

Conversation

vamsii777
Copy link
Contributor

Adds support for X (formerly Twitter) OAuth integration.

Changes

  • Add ImperialX library target and dependencies
  • Include swift-crypto package dependency

⚠️ This PR depends on

fpseverino and others added 30 commits November 10, 2024 13:49
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
@fpseverino
Copy link
Member

fpseverino commented Dec 13, 2024

Hi!
#109 changed the API a bit, to name a few:

  • a lot of stuff that was public isn't anymore
  • all classes are structs now
  • OAuthService doesn't exist anymore

I suggest you to look at other services implementation in the new beta

Also, do we need to explicitly add a dependency to swift-crypto? Vapor should even expose Swift Crypto (until v5 at least 😅)

@fpseverino fpseverino mentioned this pull request Dec 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants