Skip to content

Commit

Permalink
bugfix: cannot get response size from body attr for streamed responses
Browse files Browse the repository at this point in the history
  • Loading branch information
edaniszewski committed Nov 7, 2019
1 parent 76f8ac9 commit 92a364f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion synse_server/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ async def before_response(request, response):

# We cannot use Content-Length header since that has not yet been
# calculated and added to the response headers.
if response.body is not None:
#
# Streaming responses do not have a 'body' attribute, so we cannot
# collect this data in those cases.
if hasattr(response, 'body') and response.body is not None:
self.http_resp_bytes.labels(*labels).inc(len(response.body))

@self.app.route('/metrics', methods=['GET'])
Expand Down

0 comments on commit 92a364f

Please sign in to comment.