Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost sorting on scan results. #114

Closed
MatthewHink opened this issue Mar 27, 2018 · 1 comment
Closed

Lost sorting on scan results. #114

MatthewHink opened this issue Mar 27, 2018 · 1 comment
Labels

Comments

@MatthewHink
Copy link
Contributor

Description

With the switch from python to golang we have lost the sorting on scan results.

We used to output devices in config order.

This may not be the biggest deal, but it something to note.

Related Issues

Close Criteria

Notes

@edaniszewski
Copy link
Contributor

Is sorting on scan results something we want to have? We didn't guarantee it in 1.4. The rack and board ordering was not sorted. The ordering of devices was more consistent back then as a result of how configs were processed, but one of the big issues with 1.4 and one of the big reasons that we moved to the 2.0 architecture was to fix the configuration->device instance creation flow and make it so (a) config order shouldn't matter, which it did before, and (b) we can have a device configured that fails and still be okay.

if we need sorting, we can add it in, but I don't think its something we had and then lost from the architecture change.. at least, its not something we had intentionally/by design before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants