Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort scan results by rack, board, and device #193

Merged
merged 4 commits into from
Jul 16, 2018
Merged

Conversation

edaniszewski
Copy link
Contributor

We never really had true/complete sorting of scan results -- it used to just be sorted by rack id. Prior to that, it didn't have any sorting, but there was more consistency just based on configuration order.

This PR enforces sorting at the rack, board, and device level for scan results. As we start having more devices, this makes the scan much more consistent and easier to read through as a human.

related:

@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #193 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   81.39%   81.43%   +0.04%     
==========================================
  Files          44       44              
  Lines        1290     1293       +3     
==========================================
+ Hits         1050     1053       +3     
  Misses        240      240
Impacted Files Coverage Δ
synse/cache.py 83.15% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371e56a...7f7ee73. Read the comment docs.

@edaniszewski edaniszewski merged commit a1096a6 into master Jul 16, 2018
@edaniszewski edaniszewski deleted the scan-sort branch July 16, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant