sort scan results by rack, board, and device #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never really had true/complete sorting of scan results -- it used to just be sorted by rack id. Prior to that, it didn't have any sorting, but there was more consistency just based on configuration order.
This PR enforces sorting at the rack, board, and device level for scan results. As we start having more devices, this makes the scan much more consistent and easier to read through as a human.
related: