Scan sort order if the plugin supplies it. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniszewski
approved these changes
Jul 11, 2018
|
question -- would this obviate #193 (e.g., should that PR be closed in favor of this one?) |
|
I don't think it does. This PR is sorting the devices, not rack and board. |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 81.27% 81.39% +0.11%
==========================================
Files 44 44
Lines 1282 1290 +8
==========================================
+ Hits 1042 1050 +8
Misses 240 240
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plugin sort ordinal for scans. By default it's zero for unordered scans. For ordered scans, it's up to the plugin to determine the sort order to use. Synse will order by plugin, sortOrdinal.
This is running on Wrigley.
Requires:
vapor-ware/synse-server-grpc#29
vapor-ware/synse-sdk#295
vapor-ware/synse-snmp-plugin#11
Tests will likely fail until dependent PRs merge.