Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization is not set up correctly for packaging #146

Closed
edaniszewski opened this issue Apr 23, 2018 · 0 comments · Fixed by #147
Closed

localization is not set up correctly for packaging #146

edaniszewski opened this issue Apr 23, 2018 · 0 comments · Fixed by #147
Assignees
Labels

Comments

@edaniszewski
Copy link
Contributor

after moving some stuff around I noticed that the localization code isn't working properly and was catching the fallback. this generally isnt an issue since we only really have english support right now, so it will always fall back to that and nothing will look different.

after playing around with it and doing some reading, I'm pretty sure the localization stuff isn't set up correctly for a proper python package, which is what we're installing it as in the dockerfile.

the issue is that there isn't great comprehensive documentation on how to properly include it in the python package. there are a few examples I've found, but they don't seem great. need to spend some time reading into what exactly this requires, and then updating synse server appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant