Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #147

Merged
merged 5 commits into from
Apr 23, 2018
Merged

Cleanup #147

merged 5 commits into from
Apr 23, 2018

Conversation

edaniszewski
Copy link
Contributor

This branch started out as some work for #32, so there are a few clean up items in here including:

  • adding some file header comments
  • updating some formatting
  • fixing some typos
  • updating some info in comments
  • removing some dead code

After the first pass of cleaning, I noticed in the build/run that there was weirdness with the localization/internationalization, so I jumped into that rabbit hole, which are the remaining changes here. there isn't a lot to it.. its mostly

  • some renaming
  • cleaning up the i18n.py logic a lot
  • removing dead tests as a result of the above
  • updating setup.py to properly package the data files
  • add tox/make commands for managing translation data
  • writing up docs on the translation workflow

this should fix #146

@codecov-io
Copy link

codecov-io commented Apr 23, 2018

Codecov Report

Merging #147 into master will increase coverage by 0.01%.
The diff coverage is 93.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   88.77%   88.79%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines        1114     1089      -25     
==========================================
- Hits          989      967      -22     
+ Misses        125      122       -3
Impacted Files Coverage Δ
synse/response.py 100% <ø> (ø) ⬆️
synse/scheme/write.py 100% <ø> (ø) ⬆️
synse/scheme/scan.py 100% <ø> (ø) ⬆️
synse/const.py 100% <ø> (ø) ⬆️
synse/log.py 100% <ø> (ø) ⬆️
synse/scheme/plugins.py 100% <ø> (ø) ⬆️
synse/scheme/version.py 100% <ø> (ø) ⬆️
synse/scheme/transaction.py 100% <ø> (ø) ⬆️
synse/commands/plugins.py 100% <ø> (ø) ⬆️
synse/scheme/base_response.py 100% <ø> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a998ba0...6e4d568. Read the comment docs.

@edaniszewski edaniszewski merged commit 0b1950a into master Apr 23, 2018
@edaniszewski edaniszewski deleted the cleanup branch April 23, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localization is not set up correctly for packaging
3 participants