Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what device types should be allowable via the boot target/power routes? #153

Closed
edaniszewski opened this issue May 1, 2018 · 1 comment

Comments

@edaniszewski
Copy link
Contributor

If doing a raw write, the device type isn't checked (since write is general). If using the /power/... or /boot_target/... routes though, device types are checked preemptively to make sure that the given device does actually support that command.

We currently have

route type(s)
/power/... power
/boot_target/... system

My question is: should those be the only allowable types? My question stems from work on the IPMI plugin. There, chassis power is currently a power type device, but chassis boot target is currently a boot_target device.

The system device isn't really used by anything else IIRC.

@edaniszewski
Copy link
Contributor Author

I think this was 'fixed', or at least a decision was made, in the PR referenced above. Now, multiple device types are permissible on an endpoint, and boot target allows types system and boot_target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant