Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a boot-target type #154

Merged
merged 1 commit into from
May 7, 2018
Merged

add a boot-target type #154

merged 1 commit into from
May 7, 2018

Conversation

edaniszewski
Copy link
Contributor

The boot_target endpoint previously checked that the device type was system. This adds a boot_target type, which is used by the IPMI plugin and will be used by the AMT plugin.

It changes up the validation function to allow multiple types for an endpoint. Updates tests.

related to #153

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #154 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   89.77%   89.82%   +0.05%     
==========================================
  Files          41       41              
  Lines        1105     1111       +6     
==========================================
+ Hits          992      998       +6     
  Misses        113      113
Impacted Files Coverage Δ
synse/routes/aliases.py 98.85% <100%> (ø) ⬆️
synse/const.py 100% <100%> (ø) ⬆️
synse/validate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14822d...5513a46. Read the comment docs.

@edaniszewski edaniszewski merged commit 07c7b64 into master May 7, 2018
@edaniszewski edaniszewski deleted the boot-target-type branch May 7, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants