Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket message handler cleanup breaks with websockets 8.0 #340

Closed
edaniszewski opened this issue Oct 25, 2019 · 0 comments
Closed

websocket message handler cleanup breaks with websockets 8.0 #340

edaniszewski opened this issue Oct 25, 2019 · 0 comments

Comments

@edaniszewski
Copy link
Contributor

When doing some local dev work and updating deps, websockets got bumped to 8.0, which caused some test failures around:

>       if ws.close_connection_task is not None:
E       AttributeError: 'WebSocketCommonProtocol' object has no attribute 'close_connection_task'

we currently use the close_connection_task to add a callback to clean up the message handler tasks once the connection is terminated.

Pinning the websockets version to 7.0 works for now. This issue is to investigate how to update the message handler task cleanup such that it works with the latest version of websockets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant