New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in websocket close callback #343

Merged

edaniszewski merged 1 commit into v3/staging from websocket-dep

Oct 31, 2019

Contributor

edaniszewski commented Oct 31, 2019

This PR:

updates deps, bringing websockets to 8.0.2
fixes a bug due to a breaking change in dependency update - now, the close task will not exist on init, but will be created on connect. this doesn't seem like it would have been an issue for normal run of synse-server, but it posed issues with tests. this adds a check to ensure the attribute exists.

fixes #340


          fix bug in websocket close callback

382598d

edaniszewski requested a review from hoanhan101

October 31, 2019 17:58

hoanhan101 approved these changes

View reviewed changes

edaniszewski merged commit 76f8ac9 into v3/staging

edaniszewski deleted the websocket-dep branch

October 31, 2019 18:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment