Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate: potential bug resetting plugin to active on refresh #351

Closed
edaniszewski opened this issue Jan 29, 2020 · 0 comments
Closed
Assignees

Comments

@edaniszewski
Copy link
Contributor

possible bug, related to #349

I didn't observe this yet, but based on my recent work in #349, I realize there may be another bug in the plugin refresh. It may be nothing, this issue is more of a reminder to investigate and verify if it is an issue or not, and if so to fix it.

My thought is that I don't recall there being anywhere in the refresh logic that checks whether a plugin is active or not on refresh, and if it was inactive but succeeded refresh grpc requests, change its state back to active. It may be there and I missed it, but worth investigating since now reads/scans are gated on active state to reduce overhead wait time on grpc timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant