Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin refresh does not behave correctly #349

Closed
edaniszewski opened this issue Jan 22, 2020 · 1 comment
Closed

plugin refresh does not behave correctly #349

edaniszewski opened this issue Jan 22, 2020 · 1 comment
Labels
Projects

Comments

@edaniszewski
Copy link
Contributor

It was discovered that the plugin refresh mechanics are not working correctly. What was done to discover this was:

  • create a plugin, have it be registered with synse
  • check the /plugin endpoint and see it there and active
  • terminate the plugin
  • check the /plugin endpoint, see that it is now inactive
  • start a new set of plugins

The new set of plugins does not show up in the /plugin output because of various checks/assumptions gating the plugin refresh.

To fix this, I believe two things can be added:

  • a refresh query param on the plugin endpoint -- this should allow a manual triggering of plugins to be refreshed. The API docs should be updated accordingly.
  • a background task to periodically refresh plugins. This would likely also need a config value to set the refresh rate.
@edaniszewski
Copy link
Contributor Author

work for this complete in the above referenced PR

Synse v3 automation moved this from To do to Done Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Synse v3
  
Done
Development

No branches or pull requests

1 participant