Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: update plugin refresh triggers, gate actions on plugin status #350

Merged
merged 1 commit into from
Jan 28, 2020
Merged

bugfix: update plugin refresh triggers, gate actions on plugin status #350

merged 1 commit into from
Jan 28, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds an explicit trigger via api to refresh plugins
  • adds background task to refresh plugins
  • gates some actions (read/scan) on plugin status, so they will not attempt to operate on inactive plugins (refresh will reset them to active state if they are reachable/ok by then)
  • adds/updates tests
  • updates dependencies

fixes #349

hoanhan101
hoanhan101 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@hoanhan101 hoanhan101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe the next thing is to update the api doc if not done yet?

@edaniszewski edaniszewski mentioned this pull request Jan 28, 2020
Closed
@edaniszewski edaniszewski merged commit 634e6da into v3/staging Jan 28, 2020
@edaniszewski edaniszewski deleted the v3/plugin-refresh branch January 28, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoanhan101 hoanhan101 hoanhan101 approved these changes

@marcoceppi marcoceppi Awaiting requested review from marcoceppi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edaniszewski @hoanhan101