Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve configuration field access pattern #54

Closed
edaniszewski opened this issue Feb 23, 2018 · 0 comments
Closed

improve configuration field access pattern #54

edaniszewski opened this issue Feb 23, 2018 · 0 comments
Assignees
@edaniszewski
Labels
enhancement

Comments

@edaniszewski
Copy link
Contributor

Description

Right now, it works, but it could be done in a cleaner, more intuitive way, e.g.

config.options.get('plugin', {}).get('unix', {})

could become

config.options.get('plugin.unix')
@edaniszewski edaniszewski self-assigned this Feb 23, 2018
@edaniszewski edaniszewski mentioned this issue Mar 8, 2018
Merged
edaniszewski pushed a commit that referenced this issue Apr 5, 2018
@MatthewHink
Merge pull request #54 from vapor-ware/mhink-remove-vapor_common-depe…
2dbbc4b 
…ndency

Remove Makefile includes pointing at vapor_common.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edaniszewski edaniszewski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edaniszewski