Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'fan speed' should become 'percent' for fan writes #74

Closed
edaniszewski opened this issue Feb 28, 2018 · 1 comment
Closed

'fan speed' should become 'percent' for fan writes #74

edaniszewski opened this issue Feb 28, 2018 · 1 comment
Assignees
@edaniszewski
Labels
enhancement

Comments

@edaniszewski
Copy link
Contributor

Description

Not everything supports an RPM setting, so to make the interface more uniform across all kinds of devices, we should make 'fan_speed' become 'percent'
@edaniszewski edaniszewski self-assigned this Feb 28, 2018
@edaniszewski
Copy link
Contributor Author

as an update - we should support both rpm and percent query parameters for fan devices.

@edaniszewski edaniszewski mentioned this issue Mar 20, 2018
Merged
edaniszewski added a commit that referenced this issue Apr 5, 2018
@edaniszewski
Merge pull request #74 from vapor-ware/iss28
60841ce 
Iss28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edaniszewski edaniszewski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edaniszewski