Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0 merge #119

Merged
merged 636 commits into from
Apr 5, 2018
Merged

V2.0 merge #119

merged 636 commits into from
Apr 5, 2018

Conversation

edaniszewski
Copy link
Contributor

Review Deadline: --

Summary

merges master into v2.0-dev so that v2.0-dev can be merged into master and become the actual active branch

this bit of git indirection is because the 2.0 branch didn't share commit history with master, so by merging master in, we get its commit history. I don't think this warrants a review (700 files changed...) - it should just effectively make v2.0-dev master.

built, ran, tested, and linted locally and it looks like everything is happy.

edaniszewski and others added 23 commits March 22, 2018 14:14
Get end-to-end tests working again
Revert "change fan route params to 'rpm' and 'percent'"
make all timestamps rfc3339 formatted
add newline at end of JSON response when pretty printing
add more validation against request query params
update synse server led api to make blink an led power state
Update fan_sensors route for auto fan.
@KylerBurke KylerBurke self-requested a review April 5, 2018 16:49
Copy link
Contributor

@KylerBurke KylerBurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍔 👍 🍔
Can't wait to see how this goes! Tests are passing

@edaniszewski edaniszewski merged commit 0989894 into master Apr 5, 2018
@edaniszewski edaniszewski deleted the v2.0-merge branch April 5, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants